Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the pathfinding logic in the
tilepackage, focusing on improving performance and simplifying the codebase. The most important changes include replacing the heap-based priority queue with a bucket-based frontier, optimizing the pathfinding state management, and updating the benchmarks and tests to reflect these changes. Most of the changes are thanks to quasilyte/pathing (see deck zero-alloc-pathfinding). Replacing the heap with his priority queue and replacing the visited map with my int-int map simplified implementation and achieved general speedup of 5-40x, making me wonder what I was thinking when implementing this pathfinding a few years ago.Pathfinding Optimization:
frontierfor more efficient pathfinding (path.go,point.go). [1] [2] [3]pathfinderstruct to manage pathfinding state and optimized state acquisition and release using a sync pool (path.go). [1] [2]intmapfor better performance and reduced memory usage (path.go). [1] [2]Benchmark and Test Updates:
path_test.go). [1] [2] [3]path_test.go). [1] [2]Dependency Update:
github.com/kelindar/intmapdependency to thego.modfile.